-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SENSEI: SoA Particle Support #3349
Conversation
Add support for pure SoA layouted particle containers for SENSEI.
cc @c-wetterer-nelson @patrickoleary @burlen for the discussion we had today |
Also, since all of our particle classes are templates, and there's no instantiations inside AMReX, the CI builds don't compile them, and any bugs won't be caught there. I think we probably need to add regression tests that create an instance and exercise it. We've been using the tutorials and various AMReX downstream codes for testing. |
this looks great! +1 I do appreciate the new |
I think our exposure to this change is limited to WarpX and the AMReX tutorials. @c-wetterer-nelson would you be able to try out the tutorial and see what if any changes are needed? |
The CI test is compiling now - @burlen @c-wetterer-nelson do you think one of you could try this out on the tutorial? |
This looks great, good to merge from my side! 🎉 Thank you @atmyers for all the work! |
Summary
Add support for pure SoA layouted particle containers for SENSEI.
Additional background
Follow-up to #2878.
Checklist
The proposed changes: